This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Vote locks for all reasons except RESERVE #13914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muharem
added
A0-please_review
muharem
commented
Apr 14, 2023
muharem
added
D9-needsaudit 👮
joepetrowski
approved these changes
Apr 19, 2023
jakoblell
added
D1-audited 👍
gilescope
approved these changes
Apr 24, 2023
|
bot merge |
|
Waiting for commit status. |
|
Merge cancelled due to error. Error: Statuses failed for 03d3fd2 |
|
bot rebase |
|
Rebased |
|
bot merge |
gpestana
pushed a commit
that referenced
this pull request
May 4, 2023
* Vote locks tip * except reserve * reason for delegate * fix tests --------- Co-authored-by: parity-processbot <>
15 tasks
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
* Vote locks tip * except reserve * reason for delegate * fix tests --------- Co-authored-by: parity-processbot <>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Votes and delegations should lock for all reasons except RESERVE.
The changes do not change anything for clients who uses the latest version of balances pallet (Currency and fungibles from it). Since those implementations ignore the reason.