This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
frame-support-procedural: Fix detection of the tuples feature #13996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We didn't had the tuples features declared for the `frame-support-procedural` crate and thus, it could not properly detect that the feature was already enabled.
bkchr
added
A2-insubstantial
sam0x17
approved these changes
Apr 24, 2023
ggwpez
approved these changes
Apr 24, 2023
|
bot merge |
|
Waiting for commit status. |
paritytech-processbot
bot
deleted the
bkchr-fix-tuples-feature-detection
branch
|
Thanks - that's a really neat way of fixing it. |
gpestana
pushed a commit
that referenced
this pull request
May 4, 2023
We didn't had the tuples features declared for the `frame-support-procedural` crate and thus, it could not properly detect that the feature was already enabled.
15 tasks
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
…tech#13996) We didn't had the tuples features declared for the `frame-support-procedural` crate and thus, it could not properly detect that the feature was already enabled.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We didn't had the tuples features declared for the
frame-support-proceduralcrate and thus, it could not properly detect that the feature was already enabled.