This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
remote-externalities: batch insert key/values #14004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamaharon
added
A0-please_review
ggwpez
approved these changes
Apr 25, 2023
bkchr
approved these changes
Apr 25, 2023
arkpar
reviewed
Apr 25, 2023
arkpar
approved these changes
Apr 25, 2023
crystalin
pushed a commit
to moonbeam-foundation/substrate
that referenced
this pull request
May 3, 2023
* add batch inserting into remote externalities * use into_iter * remove redundant comment * redundant batch insert * avoid extra vec allocations
gpestana
pushed a commit
that referenced
this pull request
May 4, 2023
* add batch inserting into remote externalities * use into_iter * remove redundant comment * redundant batch insert * avoid extra vec allocations
15 tasks
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
* add batch inserting into remote externalities * use into_iter * remove redundant comment * redundant batch insert * avoid extra vec allocations
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested by @arkpar (#13562 (comment)), adds batch inserting of key/value pairs to remote-externalities so the trie root doesn't need to be re-computed after every insertion.
some (totally unscientific) try-runtime benchmarks
at
ws://localhost:9944is an (optimised build) kusama nodeon-runtime-upgrade(live)on-runtime-upgrade(live)create-snapshotcreate-snapshoton-runtime-upgrade(snap)on-runtime-upgrade(snap)