Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

improve staking interface methods #14023

Merged
merged 9 commits into from
Apr 27, 2023
Merged

improve staking interface methods #14023

merged 9 commits into from
Apr 27, 2023

Conversation

kianenigma
Copy link
Contributor

a few minot changes, in prep of target list PRs.

  • Moves StakerStatus to the primitives crate, and provides a handy fn status using it.
  • Tests for the aforementioned.
  • Make Stake<_> be generic only over Balance.

@kianenigma kianenigma added the A0-please_review Pull request needs code review. label Apr 26, 2023
@kianenigma kianenigma marked this pull request as ready for review April 26, 2023 15:37
@kianenigma kianenigma requested a review from a team April 26, 2023 15:37
@kianenigma kianenigma added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Apr 26, 2023
@kianenigma kianenigma requested a review from Ank4n April 26, 2023 15:38
gpestana
gpestana approved these changes Apr 26, 2023
View reviewed changes
Copy link
Contributor

@gpestana gpestana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kianenigma
Copy link
Contributor Author

bot rebase

@paritytech-processbot
Copy link

Rebased

@kianenigma
Copy link
Contributor Author

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot
Copy link

Merge cancelled due to error. Error: Statuses failed for d6fce82

@kianenigma
Copy link
Contributor Author

bto rebase

@kianenigma
Copy link
Contributor Author

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot paritytech-processbot bot merged commit 58be496 into master Apr 27, 2023
@paritytech-processbot paritytech-processbot bot deleted the kiz-improve-staking-interface branch April 27, 2023 11:27
gpestana pushed a commit that referenced this pull request May 4, 2023
@kianenigma @gpestana
improve staking interface methods (#14023)
3b05747 
* improve staking interface methods

* fix

* fix

* fix build

* restart

* fix

---------

Co-authored-by: parity-processbot <>
@kacperzuk-neti kacperzuk-neti mentioned this pull request Jun 23, 2023
Merged
15 tasks
@kianenigma kianenigma mentioned this pull request Jul 6, 2023
Merged
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
@kianenigma @nathanwhit
improve staking interface methods (paritytech#14023)
d442d0e 
* improve staking interface methods

* fix

* fix

* fix build

* restart

* fix

---------

Co-authored-by: parity-processbot <>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gpestana gpestana gpestana approved these changes

@Ank4n Ank4n Ank4n approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kianenigma @gpestana @Ank4n