Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Update codeowners file #14078

Merged
merged 5 commits into from
May 5, 2023
Merged

Update codeowners file #14078

merged 5 commits into from
May 5, 2023

Conversation

juangirini
Copy link
Contributor

Updates the CODEOWNERS file

Fixes #14054

@juangirini juangirini added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels May 4, 2023
@juangirini juangirini requested review from kianenigma, ggwpez and a team May 4, 2023 09:30
@juangirini juangirini marked this pull request as ready for review May 4, 2023 09:31
Copy link
Member

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

docs/CODEOWNERS Show resolved Hide resolved
docs/CODEOWNERS Show resolved Hide resolved
@juangirini juangirini requested a review from cheme May 4, 2023 16:44
@juangirini juangirini requested a review from ggwpez May 4, 2023 16:44
@ggwpez
Copy link
Member

ggwpez commented May 4, 2023

Hm i have on idea how to approve on behalf of the team or not 😆

docs/CODEOWNERS Outdated Show resolved Hide resolved
@kianenigma
Copy link
Contributor

kianenigma commented May 5, 2023

Cool, so this is useful if @paritytech/frame-coders actually look at their notifications though, which I hope they do 😜

@kianenigma
Copy link
Contributor

I wonder if some pallets that are handled by @joepetrowski and team can also have dedicated owners; eg uniques and NFT to @jsidorenko?

juangirini and others added 3 commits May 5, 2023 13:49
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
@juangirini
Copy link
Contributor Author

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
* update codeowners file

* reorganise codeowners file

* Update docs/CODEOWNERS

Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>

* add nfts and uniques ownership

* sort codeowners alphabetically

---------

Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Meta/PM] Update CODEOWNERS
4 participants