This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Reduce consensus gossip spam #1538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
andresilva
commented
Jan 23, 2019
andresilva
commented
- Only broadcast grandpa messages if the node is an authority in the current set
- Keep known consensus gossip messages for twice their expiration time
rphmeier
reviewed
Jan 23, 2019
| @@ -1524,6 +1533,7 @@ pub fn run_grandpa<B, E, Block: BlockT<Hash=H256>, N, RA>( | |||
| ); | |||
|
|
|||
| let committer_data = committer_communication( | |||
| config.local_key.clone(), | |||
There was a problem hiding this comment.
we might rather want to move the logic for checking if we are a current voter to just above this function call. Then the outgoing_messages for every round will also be a no-op.
config.local_key = config.local_key.filter(|pair| voters.contains_key(&pair.public().into()))
gavofyork
approved these changes
Jan 23, 2019
rphmeier
pushed a commit
that referenced
this pull request
Jan 23, 2019
* core: keep known gossip messages for twice their expiration * core: test expiration of known gossip messages * core: only broadcast grandpa votes if authority in current set * core: only broadcast grandpa commits if authority in current set
rphmeier
pushed a commit
that referenced
this pull request
Jan 27, 2019
* core: keep known gossip messages for twice their expiration * core: test expiration of known gossip messages * core: only broadcast grandpa votes if authority in current set * core: only broadcast grandpa commits if authority in current set
MTDK1
pushed a commit
to bdevux/substrate
that referenced
this pull request
Apr 12, 2019
* core: keep known gossip messages for twice their expiration * core: test expiration of known gossip messages * core: only broadcast grandpa votes if authority in current set * core: only broadcast grandpa commits if authority in current set
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.