This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
permit setting treasury pallet initial funding through genesis #7214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkchr
reviewed
Sep 29, 2020
| ); | ||
| let account_id = <Module<T, I>>::account_id(); | ||
| let min = T::Currency::minimum_balance(); | ||
| if T::Currency::free_balance(&account_id) < min { |
There was a problem hiding this comment.
How are you setting the initial treasury balance?
Why not adding a extra_genesis parameter that is a Option<Balance> and if that is None we set the initial balance to ED and otherwise to the given value?
There was a problem hiding this comment.
we set treasury pallet initial balance through genesis endowed_accounts, for example append Treasury::account_id(), if we use a new extra_genesis parameter to control the value in treasury pallet self, seems it will cause imbalance, we hope the Balances::total_issuance() could include this initial value.
There was a problem hiding this comment.
I think having Option<Balance> in treasury config is also good, but this way is fine too
gui1117
approved these changes
Oct 1, 2020
gui1117
added
A0-please_review
bkchr
approved these changes
Oct 1, 2020
liuchengxu
pushed a commit
to liuchengxu/substrate
that referenced
this pull request
Oct 5, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Treasury pallet will set initial balances to account ED, this will cause conflict if we want to set treasury initial funding in genesis, the change is to add a check before setting treasury balances to ED (only when balance is lower than ED)