This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
babe: introduce a request-answering mechanic #7833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rphmeier
added
A0-please_review
|
I'm not totally sure I need this, given #7789, but maybe it's useful? Cheaper than going to runtime for sure. And breaks our reliance on state pruning, but in my use-case we also do other state requests, so this isn't the only place. |
bkchr
reviewed
Jan 5, 2021
client/consensus/babe/src/lib.rs
Outdated
| ), | ||
|
|
||
| #[doc(hidden)] | ||
| __Nonexhaustive, |
There was a problem hiding this comment.
andresilva
approved these changes
Jan 6, 2021
| ) | ||
| .map_err(|e| Error::<B>::ForkTree(Box::new(e)))? | ||
| .ok_or_else(|| Error::<B>::FetchEpoch(parent_hash))?; | ||
|
|
client/consensus/babe/src/lib.rs
Outdated
| ), | ||
|
|
||
| #[doc(hidden)] | ||
| __Nonexhaustive, |
seunlanlege
reviewed
Jan 7, 2021
gnunicorn
added
the
A5-stale
|
any progress on this? |
|
@gnunicorn pretty sure it's ready |
bkchr
approved these changes
Mar 4, 2021
KalitaAlexey
pushed a commit
to KalitaAlexey/substrate
that referenced
this pull request
Jul 9, 2021
* babe: introduce a request-answering mechanic * gromble * send method
jordy25519
pushed a commit
to cennznet/substrate
that referenced
this pull request
Sep 17, 2021
* babe: introduce a request-answering mechanic * gromble * send method
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, the only request type it answers is requesting the epoch that a child block will have.