Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Migrate pallet-babe to pallet attribute macro. #8310

Merged
5 commits merged into from
Mar 17, 2021

Conversation

shaunxw
Copy link
Contributor

@shaunxw shaunxw commented Mar 10, 2021

Part of #7882.

Converts the Babe pallet to the new pallet attribute macro introduced in #6877.

Following the upgrade guidelines here: https://crates.parity.io/frame_support/attr.pallet.html#upgrade-guidelines.

⚠️ Breaking Change ⚠️

From https://crates.parity.io/frame_support/attr.pallet.html#checking-upgrade-guidelines

storages now use PalletInfo for module_prefix instead of the one given to decl_storage: Thus any use of this pallet in construct_runtime! should be careful to update name in order not to break storage or to upgrade storage (moreover for instantiable pallet). If pallet is published, make sure to warn about this breaking change.

So users of the Babe pallet must be careful about the name they used in construct_runtime!. Hence the runtime-migration label, which might not be needed depending on the configuration of the Babe pallet.

Copy link
Contributor

@gui1117 gui1117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, polkadot and kusama use Babe for the name of the pallet, thus no migration needed

@gui1117 gui1117 requested a review from ascjones March 17, 2021 16:06
@gui1117 gui1117 added A0-please_review Pull request needs code review. B3-apinoteworthy C1-low PR touches the given topic and has a low impact on builders. D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Mar 17, 2021
Copy link
Contributor

@ascjones ascjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shawntabrizi
Copy link
Member

bot merge

@ghost
Copy link

ghost commented Mar 17, 2021

Checks failed; merge aborted.

@shawntabrizi
Copy link
Member

bot merge force

@ghost
Copy link

ghost commented Mar 17, 2021

Trying merge.

@ghost
Copy link

ghost commented Mar 17, 2021

Merge failed: "Required status check \"check-labels\" is failing."

@shawntabrizi
Copy link
Member

bot merge

@ghost
Copy link

ghost commented Mar 17, 2021

Trying merge.

@ghost ghost merged commit ce0b69a into paritytech:master Mar 17, 2021
@shaunxw shaunxw deleted the sw/migrate-pallet-babe branch March 24, 2021 08:24
hirschenberger pushed a commit to hirschenberger/substrate that referenced this pull request Apr 14, 2021
* Migrate pallet-babe to pallet attribute macro.

* Remove unnecessary bound in pallet storage.

Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants