Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Migrate pallet-recovery to pallet attribute macro #8761

Merged
5 commits merged into from
May 12, 2021

Conversation

shaunxw
Copy link
Contributor

@shaunxw shaunxw commented May 8, 2021

Part of #7882.

Converts the Recovery pallet to the new pallet attribute macro introduced in #6877.

Following the upgrade guidelines here: https://crates.parity.io/frame_support/attr.pallet.html#upgrade-guidelines.

⚠️ Breaking Change ⚠️

From https://crates.parity.io/frame_support/attr.pallet.html#checking-upgrade-guidelines

storages now use PalletInfo for module_prefix instead of the one given to decl_storage: Thus any use of this pallet in construct_runtime! should be careful to update name in order not to break storage or to upgrade storage (moreover for instantiable pallet). If pallet is published, make sure to warn about this breaking change.

So users of the Recovery pallet must be careful about the name they used in construct_runtime!. Hence the runtime-migration label, which might not be needed depending on the configuration of the Recovery pallet.

@shawntabrizi shawntabrizi added B7-runtimenoteworthy C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels May 9, 2021
@gui1117
Copy link
Contributor

gui1117 commented May 12, 2021

bot merge

@ghost
Copy link

ghost commented May 12, 2021

Waiting for commit status.

@ghost ghost merged commit 53782ae into paritytech:master May 12, 2021
@shaunxw shaunxw deleted the sw/migrate-pallet-recovery branch May 12, 2021 20:37
nazar-pc pushed a commit to autonomys/substrate that referenced this pull request Aug 8, 2021
* Migrate pallet-recovery to pallet attribute macro.

* Fix metadata inconsistency.

* Use DispatchResult as call returns.

* Apply review suggestions.
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants