This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Make wasmtime the default when the feature is enabled #8855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkchr
added
A0-please_review
coriolinus
approved these changes
May 19, 2021
kianenigma
reviewed
May 19, 2021
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
kianenigma
approved these changes
May 19, 2021
|
bot merge |
|
Waiting for commit status. |
ghost
merged commit 
cecton
reviewed
May 20, 2021
| @@ -51,7 +51,7 @@ pub struct TryRuntimeCmd { | |||
| #[structopt( | |||
| long = "wasm-execution", | |||
| value_name = "METHOD", | |||
| possible_values = &WasmExecutionMethod::enabled_variants(), | |||
| possible_values = &WasmExecutionMethod::variants(), | |||
| case_insensitive = true, | |||
| default_value = "Interpreted" | |||
There was a problem hiding this comment.
Is it intended that the default value is still interpreted here while in import-params it depends on the compilation flags?
nazar-pc
pushed a commit
to autonomys/substrate
that referenced
this pull request
Aug 8, 2021
* Make wasmtime the default when the feature is enabled * Update client/cli/src/arg_enums.rs Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com> Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.