Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spec_version warnings should be logged after migrations are executed #45

Closed
liamaharon opened this issue Oct 22, 2023 · 0 comments · Fixed by #58
Closed

spec_version warnings should be logged after migrations are executed #45

liamaharon opened this issue Oct 22, 2023 · 0 comments · Fixed by #58
Assignees
@liamaharon
Labels
enhancement New feature or request

Comments

@liamaharon
Copy link
Contributor

liamaharon commented Oct 22, 2023 •
edited
Loading

Currently spec version checks are executed and warnings logged before any migrations run, making them easily missed if the migrations are noisy.

The warning should be logged at the end, to reduce the chance of it being missed by the developer.

The process should also exit with a non-zero status code when there is a spec_version warning, unless disabled.
@liamaharon liamaharon added the enhancement New feature or request label Oct 22, 2023
@liamaharon liamaharon self-assigned this Oct 22, 2023
@liamaharon liamaharon mentioned this issue Oct 22, 2023
Merged
@liamaharon liamaharon assigned liamaharon and unassigned liamaharon Oct 27, 2023
@liamaharon liamaharon mentioned this issue Nov 17, 2023
Merged
1 task
liamaharon added a commit that referenced this issue Nov 21, 2023
@liamaharon
Improve runtime check configurability (#58)
c05708e 
## Breaking changes
- Rename `--no-idempotency-checks` `--disable-idempotency-checks`
- Changes severity of failing a spec version check from a warning to
execution failure (closes
#45)
- Check spec name by default

## Other changes

- Introduce new shared param `check_spec_name`
- Introduce new `OnRuntimeUpgrade` param `check_spec_version`
- Simplify internal handling of runtime checks 

TODO
- [x] Tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@liamaharon liamaharon

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve runtime check configurability paritytech/try-runtime-cli
1 participant
@liamaharon