Ensure closing watchers does not affect other watchers #1018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the first watcher that was created gets closed all other watchers will no longer receive events. Ran into this scenario after we upgraded Next.js to use the latest chokidar that came with the latest stable watchpack. With chokidar v2 (which watchpack previously depended on) this test passes fine. Using v3 it stops reporting.
|
Ran the changes against the full test suite |
timneutkens
changed the title
|
Thank you! I’ll be reviewing/merging this in a bit. |
|
Thanks @paulmillr 🙏 |
|
Hey @paulmillr, just checking in on this as our Next.js test suite fails a few tests related to this issue. Let me know if there's any changes needed 👍 Thanks! |
|
New release is coming today |
|
Awesome! Thanks @paulmillr 🙏 |
|
Apparently github autocompleted to the wrong Paul (Paul Irish) 🤦 Thanks again @paulmillr 🙏 |
timneutkens
added a commit
to timneutkens/watchpack
that referenced
this pull request
Jul 23, 2020
Makes sure the version with this patch is installed: paulmillr/chokidar#1018
ycjcl868
added a commit
to umijs/umi
that referenced
this pull request
Aug 3, 2020
sorrycc
pushed a commit
to umijs/umi
that referenced
this pull request
Aug 3, 2020
* chore: upgrade deps * chore: @hapi/joi * chore: ref paulmillr/chokidar#1018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the first watcher that was created gets closed all other watchers will no longer receive events.
Ran into this scenario after we upgraded Next.js to use the latest chokidar that came with the latest stable watchpack. With chokidar v2 (which watchpack previously depended on) this test passes fine. Using v3 it stops reporting filesystem events.
So far I've tracked it down to this particular line:
https://github.com/paulmillr/chokidar/blob/master/lib/fsevents-handler.js#L149
Because the part that creates the context is only called on the first watcher the
fswvariable willalways refer to that first watcher.
const.listenerscont.listeners.sizeinstead offsw.closedThe symptoms (only on macOS) would be that webpack did not recompile after introducing an error or after doing a bunch of quick changes to a certain file. With the change in this PR applied the symptoms are no longer there.
The particular reason this surfaces in webpack is that when an error happens the watchers are closed and recreated when a compilation error happens as files/dependencies could have changed in between.