a better comment support for Slang #838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…omment to every method inlined and restore lost comment. Include small changes in a lot of method executed after inlinining to make it work because of end comment. change test related to inlining to include comments in their result.
change in existing test to show this behavior
…bel: to put statements between them
RenaudFondeur
force-pushed
the
betterComment
branch
from
c3eebf4
to
db9ae3a
Compare
…r:label: would place statements between them
guillep
reviewed
Aug 12, 2024
guillep
reviewed
Aug 12, 2024
| commentNode := CCommentNode new. | ||
| commentNode comment: (String streamContents: [ :s | | ||
| s space. | ||
| s nextPutAll: self comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add more comment support to Slang : ensure there is a begin and end comment to every method inlined and restore lost comment. Include small changes in a lot of method executed after inlinining to make it work because of end comment.
change tests related to inlining to include comments in their result.