Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progressive Web App support #66

Merged
merged 13 commits into from
Jul 2, 2024

Conversation

iMattPro
Copy link
Contributor

@iMattPro iMattPro commented Jun 30, 2024

Added ACP options to Board Settings for progressive web applications. These are optional but are where you can set a custom short name and the small and large icons.

Signed-off-by: Matt Friedman <maf675@gmail.com>
Signed-off-by: Matt Friedman <maf675@gmail.com>
Signed-off-by: Matt Friedman <maf675@gmail.com>
Signed-off-by: Matt Friedman <maf675@gmail.com>
@iMattPro
Copy link
Contributor Author

@marc1706 Experimenting with something else here. On iOS devices, web push notifications don't work unless the site is a "Progressive Web Application." That just means it needs some meta tags, some optional touch screen app icons, and a manifest.json file. This PR is looking to add that to the extension, which if works out, should probably go into the core too.

Signed-off-by: Matt Friedman <maf675@gmail.com>
Signed-off-by: Matt Friedman <maf675@gmail.com>
Signed-off-by: Matt Friedman <maf675@gmail.com>
Signed-off-by: Matt Friedman <maf675@gmail.com>
Signed-off-by: Matt Friedman <maf675@gmail.com>
Signed-off-by: Matt Friedman <maf675@gmail.com>
Signed-off-by: Matt Friedman <maf675@gmail.com>
Signed-off-by: Matt Friedman <maf675@gmail.com>
Signed-off-by: Matt Friedman <maf675@gmail.com>
@iMattPro iMattPro merged commit f6ad9a3 into phpbb-extensions:main Jul 2, 2024
32 checks passed
@iMattPro iMattPro deleted the progressive-web-app branch July 2, 2024 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants