Enable SSL for all server #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: TasdidurRahman <tasdid@appscode.com>
|
wrong upstream |
If you want you can contribute adding support for SSL via ENVs |
Signed-off-by: TasdidurRahman <tasdid@appscode.com>
|
hi @williamdes, can you review this? |
williamdes
requested changes
Aug 19, 2024
There was a problem hiding this comment.
Please update https://github.com/phpmyadmin/docker/blob/master/config.inc.php
And run ./update.sh
Can you also add documentation on the README ?
It is unclear how to use this
PMA_SSLS="0,1" is maybe not very user friendly
Signed-off-by: TasdidurRahman <tasdid@appscode.com>
imo this is better to keep it simple as we are not using CA rn. still we are open for suggestion! |
williamdes
requested changes
Aug 19, 2024
Signed-off-by: TasdidurRahman <tasdid@appscode.com>
williamdes
reviewed
Aug 19, 2024
williamdes
reviewed
Aug 19, 2024
Signed-off-by: TasdidurRahman <tasdid@appscode.com>
MauricioFauth
approved these changes
Aug 19, 2024
|
I sent your changes to the official registry: docker-library/official-images#17398 TODO myself:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enable ssl connection with upstream. no ca used.
variable introduced:
PMA_SSLfor single upstreamPMA_SSLSfor multiple upstreamdocker run ... -e PMA_HOSTS="mysql-notls,mysql-tls" -e PMA_SSLS="0,1" ...