Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimizations & refactoring #46

Merged
merged 6 commits into from
Sep 16, 2023

Conversation

kamil-tekiela
Copy link
Contributor

This contains some small performance improvements.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.07% ⚠️

Comparison is base (ad0a108) 99.35% compared to head (4d7a3f8) 99.29%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #46      +/-   ##
============================================
- Coverage     99.35%   99.29%   -0.07%     
+ Complexity      110      108       -2     
============================================
  Files             8        8              
  Lines           312      285      -27     
============================================
- Hits            310      283      -27     
  Misses            2        2              
Flag Coverage Δ
unit-8.1-ubuntu-latest 99.29% <100.00%> (-0.07%) ⬇️
unit-8.2-ubuntu-latest 99.29% <100.00%> (-0.07%) ⬇️
unit-8.3-ubuntu-latest 99.29% <100.00%> (-0.07%) ⬇️
unit-8.4-ubuntu-latest 99.29% <100.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/Cache/InMemoryCache.php 100.00% <ø> (ø)
src/Loader.php 100.00% <100.00%> (ø)
src/MoParser.php 100.00% <100.00%> (ø)
src/Translator.php 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MauricioFauth MauricioFauth added this to the 6.0.0 milestone Sep 15, 2023
@MauricioFauth MauricioFauth merged commit 39b6055 into phpmyadmin:master Sep 16, 2023
13 checks passed
@MauricioFauth MauricioFauth self-assigned this Sep 16, 2023
@kamil-tekiela kamil-tekiela deleted the Optimizations branch September 16, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants