Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL query editor: MariaDB window function with alias gives bad linting errors #283

Closed
markus-ksg opened this issue Jan 17, 2020 · 3 comments · Fixed by #487
Closed

SQL query editor: MariaDB window function with alias gives bad linting errors #283

markus-ksg opened this issue Jan 17, 2020 · 3 comments · Fixed by #487
Assignees
Labels
Milestone

Comments

@markus-ksg
Copy link

Describe the bug

A MariaDB window function used together with an alias results in bad linting errors in the SQL query editor.

To Reproduce

  1. Go to https://demo.phpmyadmin.net/master-config/index.php?route=/table/sql&db=opengis&table=world_borders&server=1
  2. Enter query:
SELECT *, COUNT(*) OVER(PARTITION BY `REGION`) AS 'count(REGION)' FROM `world_borders`

=> Linting errors:

phpmyadmin-linting-error

Expected behavior

No error. Query is correct and executes fine.

Server configuration

  • phpMyAdmin version: latest (5.1.0)

Client configuration

  • Browser: Firefox
  • Operating system: Windows 10

Additional context

The error only shows up if there is an AS 'label'.

@san-ki
Copy link

san-ki commented Jun 21, 2023

this has not yet resolved i guess. i am getting same error

@williamdes
Copy link
Member

this has not yet resolved i guess. i am getting same error

most probably since it's still open
Maybe it's a challenge @niconoe- would like to solve?

@niconoe-
Copy link
Contributor

I'll take a deeper look as I'm a little bit free today, but at the first sight, it's not really an easy fix… I can't promise anything

@williamdes williamdes self-assigned this Jun 29, 2023
@williamdes williamdes added this to the 5.9.0 milestone Jun 29, 2023
williamdes added a commit that referenced this issue Jun 29, 2023
Pull-request: #487

Signed-off-by: William Desportes <williamdes@wdes.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants