Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'",": Unrecognized alter operation' when altering table with ALGORITHM and LOCK clauses #319

Closed
PierreKerschgens opened this issue Nov 19, 2020 · 2 comments · Fixed by #440
Closed

'",": Unrecognized alter operation' when altering table with ALGORITHM and LOCK clauses #319

PierreKerschgens opened this issue Nov 19, 2020 · 2 comments · Fixed by #440
Assignees
@williamdes
Labels
bug
Milestone
5.8.0

Comments

@PierreKerschgens
Copy link

HI!

Despite I'm using your sql-parser as part of php-sqllint I think the following issue origins from sql-parser.

I have the following statement:

ALTER TABLE XXX DROP COLUMN YYY, ALGORITHM=INPLACE, LOCK=NONE;

Which results in the following false-positive:

Line 9, col 65 at ",": Unrecognized alter operation.
Line 9, col 67 at "LOCK": A new statement was found, but no delimiter between it and the previous one.
Line 9, col 67 at "LOCK": Unrecognized alter operation.

best regards!
@williamdes
Copy link
Member

Hi @PierreKerschgens
Thank you for the report !

@williamdes williamdes added this to the 4.7.2 milestone Nov 19, 2020
@williamdes williamdes added the bug label Nov 19, 2020
@williamdes williamdes modified the milestones: 4.7.2, 4.7.3 Feb 5, 2021
@williamdes williamdes modified the milestones: 4.7.3, 4.7.4 Dec 11, 2021
@williamdes williamdes modified the milestones: 4.7.4, 5.7.0 Nov 21, 2022
@williamdes williamdes modified the milestones: 5.7.0, 5.8.0 Jan 25, 2023
@Tithugues Tithugues mentioned this issue Apr 13, 2023
Merged
@williamdes williamdes self-assigned this Apr 14, 2023
williamdes added a commit that referenced this issue Apr 14, 2023
@williamdes
Add new tests for #319
6bdb41d 
Signed-off-by: William Desportes <williamdes@wdes.fr>
@williamdes
Copy link
Member

I added new tests in 6bdb41d
Before I merge #440 to fix this issue

@williamdes williamdes linked a pull request Apr 14, 2023 that will close this issue
Fix #319 - Support ALGORITHM and LOCK options in ALTER TABLE statements #440
Merged
williamdes added a commit that referenced this issue Apr 14, 2023
@williamdes
Ref #440 - Ref #319 - Update out files
696d036 
Pull-request: #440

Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes added a commit that referenced this issue Apr 14, 2023
@williamdes
Add a CHANGELOG entry for #319
d576334 
Pull-request: #440

Signed-off-by: William Desportes <williamdes@wdes.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@williamdes williamdes

Labels
bug
Projects
None yet
Milestone
5.8.0
Development

Successfully merging a pull request may close this issue.

Fix #319 - Support ALGORITHM and LOCK options in ALTER TABLE statements Tithugues/sql-parser
2 participants
@williamdes @PierreKerschgens