Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

erroneously reports syntax error when calling stored procedure with schema #372

Closed
mousumis opened this issue Nov 18, 2021 · 2 comments
Closed

erroneously reports syntax error when calling stored procedure with schema #372

mousumis opened this issue Nov 18, 2021 · 2 comments
Assignees
@williamdes
Labels
bug
Milestone
5.8.0

Comments

@mousumis
Copy link

Describe the bug

The phpMyAdmin editor shows errors about tokens when running a call statement for stored procedure with the schema included. Example screenshot is included below

To Reproduce

Steps to reproduce the behavior:

  1. Go to phpMyAdmin
  2. Click on the SQL tab
  3. Run a stored procedure call script which includes a schema
  4. Observe parsing errors though the command is correct and can execute correctly

Expected behavior

No errors should be seen in the editor

Screenshots

image

Server configuration

  • Operating system: CentOS-7
  • Web server:
  • Database version: 10.5.10-MariaDB
  • PHP version: 7.4.24
  • phpMyAdmin version: 4.9.7

Client configuration

  • Browser: Chrome
  • Operating system: MacOS

Additional context
@ibennetch
Copy link
Member

I confirm this issue (which actually exists in our sql-parser library):

./bin/lint-query --query 'call foo.bar'
phpmyadmin/phpmyadmin#1: Unexpected token. (near "bar" at position 9)

@williamdes williamdes transferred this issue from phpmyadmin/phpmyadmin Feb 7, 2022
@williamdes williamdes added the bug label Feb 7, 2022
@williamdes
Copy link
Member

Thank you for the report, I moved it in the right place

@williamdes williamdes mentioned this issue Apr 21, 2023
Merged
williamdes added a commit that referenced this issue Apr 21, 2023
@williamdes
Add test cases for #372
8bfd192 
Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes added a commit that referenced this issue Apr 21, 2023
@williamdes
Remove failing db names because of #372
74aea33 
Signed-off-by: William Desportes <williamdes@wdes.fr>
@williamdes williamdes mentioned this issue Apr 21, 2023
Merged
@williamdes williamdes added this to the 5.8.0 milestone Apr 21, 2023
@williamdes williamdes changed the title phpMyAdmin Editor erroneously reports syntax error when calling stored procedure with schema erroneously reports syntax error when calling stored procedure with schema Apr 21, 2023
williamdes added a commit that referenced this issue May 8, 2023
@williamdes
Merge #442 - Fix #372 - re-implement CALL statements parsing
0515846 
Pull-request: #442
Fixes: #372

Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes added a commit that referenced this issue May 8, 2023
@williamdes
Add a CHANGELOG entry for #372
7b1f1e5 
Pull-request: #442

Signed-off-by: William Desportes <williamdes@wdes.fr>
@williamdes williamdes self-assigned this May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@williamdes williamdes

Labels
bug
Projects
None yet
Milestone
5.8.0
Development

No branches or pull requests
3 participants
@ibennetch @mousumis @williamdes