Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PARTITION syntax error #377

Closed
williamdes opened this issue May 10, 2022 · 1 comment · Fixed by #423
Closed

PARTITION syntax error #377

williamdes opened this issue May 10, 2022 · 1 comment · Fixed by #423
Assignees
@williamdes
Labels
bug
Milestone
5.8.0

Comments

@williamdes
Copy link
Member

williamdes commented May 10, 2022 •
edited
Loading 

ALTER TABLE d PARTITION BY RANGE (MONTH(departure_date))
(
PARTITION p01 VALUES LESS THAN (02) ,
PARTITION p02 VALUES LESS THAN (03) ,
PARTITION p03 VALUES LESS THAN (04) ,
PARTITION p04 VALUES LESS THAN (05) ,
PARTITION p05 VALUES LESS THAN (06) ,
PARTITION p06 VALUES LESS THAN (07) ,
PARTITION p07 VALUES LESS THAN (08) ,
PARTITION p08 VALUES LESS THAN (09) ,
PARTITION p09 VALUES LESS THAN (10) ,
PARTITION p10 VALUES LESS THAN (11) ,
PARTITION p11 VALUES LESS THAN (12) ,
PARTITION p12 VALUES LESS THAN (13) ,
PARTITION pmaxval VALUES LESS THAN MAXVALUE 
);

Is valid but the parser show an error, missing comma [...]
image

Ref https://sudonull.com/post/134690-Mysql-PARTITION-BY-YEAR-date-MONTH-date-DAYOFWEEK-date
@williamdes williamdes added the bug label May 10, 2022
@williamdes williamdes added this to the 4.7.4 milestone May 10, 2022
@williamdes williamdes modified the milestones: 4.7.4, 5.7.0 Nov 21, 2022
@williamdes williamdes modified the milestones: 5.7.0, 5.8.0 Jan 25, 2023
niconoe- added a commit to niconoe-/sql-parser that referenced this issue Feb 28, 2023
@niconoe-
Proposal to fix phpmyadmin#377: understand correctly PARTITION BY RANGE.
dc7184e
niconoe- added a commit to niconoe-/sql-parser that referenced this issue Feb 28, 2023
@niconoe-
Fix expected out file for phpmyadmin#377 fix.
ebf620c
@niconoe- niconoe- mentioned this issue Feb 28, 2023
Merged
@williamdes williamdes self-assigned this Mar 13, 2023
williamdes added a commit that referenced this issue Mar 13, 2023
@williamdes
Add more queries to test #377
84caccb 
Signed-off-by: William Desportes <williamdes@wdes.fr>
@williamdes
Copy link
Member Author

More test cases where added in 84caccb for this issue

williamdes pushed a commit to niconoe-/sql-parser that referenced this issue Mar 13, 2023
@niconoe- @williamdes
Add a new test case for phpmyadmin#377
408e687
williamdes added a commit to niconoe-/sql-parser that referenced this issue Mar 13, 2023
@williamdes
Adjust data after fixes for phpmyadmin#377
72c52dc 
Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes added a commit that referenced this issue Mar 13, 2023
@williamdes
Merge #423 - Fix #377 - PARTITION syntax errors
f24aa16 
Pull-request: #423
Fixes: #377

Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes added a commit that referenced this issue Mar 13, 2023
@williamdes
Add a CHANGELOG entry for #377
dca8142 
Pull-request: #423

Signed-off-by: William Desportes <williamdes@wdes.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@williamdes williamdes

Labels
bug
Projects
None yet
Milestone
5.8.0
Development

Successfully merging a pull request may close this issue.

Fix #377 - PARTITION syntax errors niconoe-/sql-parser
1 participant
@williamdes