Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance improvement to use less the "nextToken()" function #397

Merged
merged 4 commits into from
Jan 6, 2023

Conversation

iifawzi
Copy link
Contributor

@iifawzi iifawzi commented Dec 7, 2022

Hi, This's an improvement to skip the current token by increasing the idx, instead of the additional nextToken call.
Signed-off-by: iifawzi iifawzie@gmail.com

…rent token

Signed-off-by: iifawzi <iifawzie@gmail.com>
@codecov
Copy link

codecov bot commented Dec 7, 2022

Codecov Report

Base: 95.59% // Head: 95.58% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (75dbc4e) compared to base (a6da770).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #397      +/-   ##
============================================
- Coverage     95.59%   95.58%   -0.01%     
  Complexity     2180     2180              
============================================
  Files            68       68              
  Lines          4701     5033     +332     
============================================
+ Hits           4494     4811     +317     
- Misses          207      222      +15     
Impacted Files Coverage Δ
src/Components/AlterOperation.php 100.00% <100.00%> (ø)
src/Statements/ExplainStatement.php 100.00% <100.00%> (ø)
src/Statements/WithStatement.php 100.00% <100.00%> (ø)
src/Token.php 100.00% <0.00%> (ø)
src/Parser.php 100.00% <0.00%> (ø)
src/Statement.php 100.00% <0.00%> (ø)
src/Utils/Misc.php 100.00% <0.00%> (ø)
src/Utils/Error.php 100.00% <0.00%> (ø)
src/Utils/Routine.php 100.00% <0.00%> (ø)
src/Utils/Formatter.php 100.00% <0.00%> (ø)
... and 28 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@iifawzi iifawzi changed the title Increasing the idx of the tokens instead of using getNext to skip current token Performance improvement to use less the "nextToken()" function Dec 7, 2022
Signed-off-by: iifawzi <iifawzie@gmail.com>
Copy link
Member

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@williamdes williamdes added this to the 5.7.0 milestone Dec 12, 2022
@williamdes williamdes self-assigned this Jan 6, 2023
@williamdes williamdes merged commit fd9e59f into phpmyadmin:master Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants