Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide new unit test + fix with ALTER EVENT RENAME TO using expression #420

Merged
merged 3 commits into from
Feb 3, 2023

Conversation

niconoe-
Copy link
Contributor

@niconoe- niconoe- commented Feb 1, 2023

No description provided.

@codecov
Copy link

codecov bot commented Feb 1, 2023

Codecov Report

Base: 97.25% // Head: 97.25% // No change to project coverage 👍

Coverage data is based on head (b95fed9) compared to base (7315fc9).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #420   +/-   ##
=========================================
  Coverage     97.25%   97.25%           
  Complexity     2196     2196           
=========================================
  Files            68       68           
  Lines          5057     5057           
=========================================
  Hits           4918     4918           
  Misses          139      139           
Impacted Files Coverage Δ
src/Components/AlterOperation.php 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@williamdes williamdes self-assigned this Feb 3, 2023
@williamdes williamdes added this to the 5.8.0 milestone Feb 3, 2023
@williamdes williamdes changed the title Provide new unit test with ALTER EVENT RENAME TO using expression. Provide new unit test + fix with ALTER EVENT RENAME TO using expression Feb 3, 2023
williamdes added a commit that referenced this pull request Feb 3, 2023
Pull-request: #420

Signed-off-by: William Desportes <williamdes@wdes.fr>
@williamdes williamdes merged commit 8e48df3 into phpmyadmin:master Feb 3, 2023
@williamdes
Copy link
Member

Thank you !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ALTER EVENT … RENAME TO new_db.new_event; fails to be understood correctly by the parser
2 participants