Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect order of operations to parse table/db called `` #422

Merged
merged 1 commit into from
Feb 26, 2023

Conversation

kamil-tekiela
Copy link
Contributor

A very minor error when the table name is ``

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
@williamdes
Copy link
Member

I think you you also add a new test for this, check out the recent PRs for examples
I can also do it if you don't have time

@codecov
Copy link

codecov bot commented Feb 17, 2023

Codecov Report

Base: 97.25% // Head: 97.23% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (2a12a4f) compared to base (b95fed9).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #422      +/-   ##
============================================
- Coverage     97.25%   97.23%   -0.02%     
  Complexity     2196     2196              
============================================
  Files            68       68              
  Lines          5057     5057              
============================================
- Hits           4918     4917       -1     
- Misses          139      140       +1     
Impacted Files Coverage Δ
src/Token.php 100.00% <100.00%> (ø)
src/Components/AlterOperation.php 99.20% <0.00%> (-0.80%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kamil-tekiela
Copy link
Contributor Author

@williamdes If you have time to do it I would be obliged. I don't have much familiarity with the parser yet.

@williamdes williamdes changed the title Incorrect order of operations causes PMA to break with table called `` Incorrect order of operations to parse table/db called `` Feb 26, 2023
williamdes added a commit that referenced this pull request Feb 26, 2023
Signed-off-by: William Desportes <williamdes@wdes.fr>
@williamdes williamdes merged commit f022373 into phpmyadmin:master Feb 26, 2023
williamdes added a commit that referenced this pull request Feb 26, 2023
Pull-request: #422

Signed-off-by: William Desportes <williamdes@wdes.fr>
@williamdes
Copy link
Member

@williamdes If you have time to do it I would be obliged. I don't have much familiarity with the parser yet.

I added a test in 19ce4bd
And updated the data (after the fix) in the merge commit: f022373

@williamdes williamdes self-assigned this Feb 26, 2023
@williamdes williamdes added this to the 5.8.0 milestone Feb 26, 2023
Copy link
Member

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

williamdes added a commit to phpmyadmin/phpmyadmin that referenced this pull request Feb 26, 2023
Ref: phpmyadmin/sql-parser#422

Signed-off-by: William Desportes <williamdes@wdes.fr>
@kamil-tekiela kamil-tekiela deleted the fix-table-name-bug branch June 1, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants