Fix #226 - Ignore end of comment string at the end of queries with MySQL-specific commands

[niconoe-]

This is an attempt to fix #226 .

If it misses some use-cases to test, please tell me.

[williamdes]

Thank you for working on the sql-parser 🚀
this fix only ignores the end, but without it what would the unit tests look like?
The queries where broken?

[niconoe-]

Thank you for working on the sql-parser 🚀
this fix only ignores the end, but without it what would the unit tests look like?
The queries where broken?

Kind of… if you look at the unit test defined in #226 , without the fix, the assertEquals fails because the content of the expression ends with the ˋ*/` token while it shouldn’t.
I don’t know how this could be interpreted but I guess if this is reused in the builder, it will create an invalid query.

[williamdes]

Kind of… if you look at the unit test defined in #226 , without the fix, the assertEquals fails because the content of the expression ends with the ˋ*/` token while it shouldn’t.
I don’t know how this could be interpreted but I guess if this is reused in the builder, it will create an invalid query.

Oh okay, could you add a regression test for this ?

[williamdes]

Or maybe the current tests would fail without you fix ?

[niconoe-]

Or maybe the current tests would fail without you fix ?

That's is. Considering the unit test testMysqlCommands I added, it would fail if my fix isn't provided.

Without my fix, it behaved exactly like the issue's OP described, while with my fix, it's now OK.

[williamdes]

Or maybe the current tests would fail without you fix ?

That's is. Considering the unit test testMysqlCommands I added, it would fail if my fix isn't provided.

Without my fix, it behaved exactly like the issue's OP described, while with my fix, it's now OK.

Awesome, ready for a merge

[williamdes]

Thank you, I rebased your work after adding more test cases in: 049ed2d