Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #450 - Parsing insert queries with functions trims commas #474

Merged
merged 1 commit into from
Jun 5, 2023

Conversation

Tithugues
Copy link
Contributor

@Tithugues Tithugues commented Jun 5, 2023

Parsing of a value must not stop when a comma is found.

Fixes: #450

Parsing of a value must not stop when a comma is found.
@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.02 ⚠️

Comparison is base (a3a699d) 97.04% compared to head (90a94fc) 97.02%.

Additional details and impacted files
@@             Coverage Diff              @@
##              5.8.x     #474      +/-   ##
============================================
- Coverage     97.04%   97.02%   -0.02%     
- Complexity     2218     2234      +16     
============================================
  Files            69       69              
  Lines          5107     5144      +37     
============================================
+ Hits           4956     4991      +35     
- Misses          151      153       +2     
Impacted Files Coverage Δ
src/Components/ArrayObj.php 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome !

@williamdes williamdes added this to the 5.8.0 milestone Jun 5, 2023
@williamdes williamdes self-assigned this Jun 5, 2023
@williamdes williamdes changed the title Fix #450 Parsing insert queries with functions trims commas Fix #450 - Parsing insert queries with functions trims commas Jun 5, 2023
williamdes added a commit that referenced this pull request Jun 5, 2023
Pull-request: #474

Signed-off-by: William Desportes <williamdes@wdes.fr>
@williamdes williamdes merged commit ef7a40d into phpmyadmin:5.8.x Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants