Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bin/sql-parser executable file #537

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

MauricioFauth
Copy link
Member

This new executable file acts only as an alias to the other executable files.

This will allow the other files to be removed in 6.0.0.

Copy link

codecov bot commented Jan 17, 2024

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (6621941) 97.03% compared to head (38959b6) 96.78%.
Report is 1 commits behind head on 5.9.x.

❗ Current head 38959b6 differs from pull request most recent head bb01d8a. Consider uploading reports for the commit bb01d8a to get more accurate results

Files Patch % Lines
src/Utils/CLI.php 61.76% 13 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##              5.9.x     #537      +/-   ##
============================================
- Coverage     97.03%   96.78%   -0.25%     
- Complexity     2245     2253       +8     
============================================
  Files            69       69              
  Lines          5155     5171      +16     
============================================
+ Hits           5002     5005       +3     
- Misses          153      166      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, do not forget to check we vendor remove it in phpMyAdmin builds

- Related to phpmyadmin#517

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
@MauricioFauth MauricioFauth merged commit 1fecd67 into phpmyadmin:5.9.x Jan 18, 2024
16 of 17 checks passed
@MauricioFauth MauricioFauth deleted the sql-parser-bin-file branch January 18, 2024 15:51
@MauricioFauth MauricioFauth self-assigned this Jan 18, 2024
@MauricioFauth MauricioFauth added this to the 5.9.0 milestone Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants