Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use character array for utfstring #561

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

MoonE
Copy link
Contributor

@MoonE MoonE commented Jun 2, 2024

Benchmarks indicate a nice performance gain, too.

Old:

benchmark subject set revs its mem_peak mode rstdev
UtfStringBench benchBuildUtfString 4 20 1.910mb 34.245ms ±1.33%
UtfStringBench benchUtfStringRandomAccessWithUnicode 4 20 1.910mb 78.063μs ±9.44%

New:

benchmark subject set revs its mem_peak mode rstdev
UtfStringBench benchBuildUtfString 4 20 2.513mb 14.636ms ±2.37%
UtfStringBench benchUtfStringRandomAccessWithUnicode 4 20 1.910mb 22.511μs ±3.69%

Copy link

codecov bot commented Jun 2, 2024

Codecov Report

Attention: Patch coverage is 70.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 96.31%. Comparing base (48bd285) to head (8026eb5).
Report is 13 commits behind head on master.

Current head 8026eb5 differs from pull request most recent head 51225c5

Please upload reports for the commit 51225c5 to get more accurate results.

Files Patch % Lines
src/Tools/TestGenerator.php 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #561      +/-   ##
============================================
- Coverage     96.55%   96.31%   -0.25%     
- Complexity     2166     2192      +26     
============================================
  Files            87       87              
  Lines          5025     5072      +47     
============================================
+ Hits           4852     4885      +33     
- Misses          173      187      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
@MoonE MoonE force-pushed the utfstring-character-array branch from 8026eb5 to 51225c5 Compare June 2, 2024 16:21
Copy link
Contributor

@kamil-tekiela kamil-tekiela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes so much sense.

@williamdes
Copy link
Member

Maybe we should target 5.10.x ?
Or keep 6.0 ?

@niconoe-
Copy link
Contributor

Maybe we should target 5.10.x ? Or keep 6.0 ?

If we are very strict about sementic versionning, keeping 6.0 makes sense because this PR removes accesses to public properties some projects could read directly, hence it causes a BC Break.

But if we are loosely respecting it, having on 5.10 makes sense also as to me, this is very internal classes and it shouldn't be accessed by external projects, hence it should not cause any BC Break.

I personnaly would go for 5.10.x, but I sometimes can be a cow-boy about it 😆 .

@MauricioFauth MauricioFauth merged commit 6bbea5b into phpmyadmin:master Aug 26, 2024
9 of 10 checks passed
@MauricioFauth MauricioFauth added this to the 6.0.0 milestone Aug 26, 2024
@MauricioFauth MauricioFauth self-assigned this Aug 26, 2024
@MoonE MoonE deleted the utfstring-character-array branch August 26, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants