-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix query flags for lower-case functions #564
Fix query flags for lower-case functions #564
Conversation
32cd6d0
to
a4f7166
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 5.9.x #564 +/- ##
=========================================
Coverage 96.79% 96.79%
- Complexity 2257 2258 +1
=========================================
Files 69 69
Lines 5172 5175 +3
=========================================
+ Hits 5006 5009 +3
Misses 166 166 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why benchmarks are not passing |
it's unexpectedly faster? What these numbers are based on? |
Oh, on what I had when I wrote the bench. Maybe we can update to quicker then |
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
a4f7166
to
35ca80b
Compare
See phpmyadmin/phpmyadmin#16869
is_func
andis_count
were only set when the function is in all upper case.