Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/from 5 9 define context keywords relying on token constants #570

Conversation

niconoe-
Copy link
Contributor

@niconoe- niconoe- commented Aug 6, 2024

Same as #569 but from 5.9.x branch.

@niconoe-
Copy link
Contributor Author

niconoe- commented Aug 6, 2024

@williamdes / @kamil-tekiela
Are you OK with these changes? I'm having issues with PHPStan about files I didn't change, and with Psalm on Generated contextes but this will be fixed on future versions (with PHP 8.2 minimum) I guess.
Benchmark issues, I don't get it too…

phpstan-baseline.neon Outdated Show resolved Hide resolved
@niconoe-
Copy link
Contributor Author

@williamdes (and maybe @MauricioFauth ) any chance to see this integrated soon? Or do you need something from me before? Thanks 🙂

@williamdes
Copy link
Member

@williamdes (and maybe @MauricioFauth ) any chance to see this integrated soon? Or do you need something from me before? Thanks 🙂

For me this is all good, only awaiting a review from @MauricioFauth

@MauricioFauth MauricioFauth changed the base branch from 5.9.x to 5.10.x August 25, 2024 16:23
@MauricioFauth MauricioFauth merged commit 9fa8ca9 into phpmyadmin:5.10.x Aug 25, 2024
11 of 17 checks passed
@MauricioFauth MauricioFauth self-assigned this Aug 25, 2024
@MauricioFauth MauricioFauth added this to the 5.10.0 milestone Aug 25, 2024
@niconoe- niconoe- deleted the feature/from-5-9-define-context-keywords-relying-on-token-constants branch August 26, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants