Add parsing of CASE Expressions #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix phpmyadmin/phpmyadmin#12100 Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
Current coverage is 99.42% (diff: 100%)@@ master #88 diff @@
==========================================
Files 51 52 +1
Lines 3337 3456 +119
Methods 171 174 +3
Messages 0 0
Branches 0 0
==========================================
+ Hits 3317 3436 +119
Misses 20 20
Partials 0 0
|
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
devenbansod
force-pushed
the
fix_pma_12100
branch
3 times, most recently
from
46bfa6f
to
f151567
Compare
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
|
This seems ready to tested and hopefully merged. |
|
Indeed it looks good! |
nijel
added a commit
that referenced
this pull request
Oct 3, 2016
Signed-off-by: Michal Čihař <michal@cihar.com>
nijel
added a commit
that referenced
this pull request
Oct 3, 2016
Signed-off-by: Michal Čihař <michal@cihar.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix phpmyadmin/phpmyadmin#12100.
Also see my comment at phpmyadmin/phpmyadmin#12100 (comment)
Tests to be added.
Signed-off-by: Deven Bansod devenbansod.bits@gmail.com