Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate the website from Python to Rust #132

Closed
Guileas opened this issue Oct 14, 2020 · 13 comments · Fixed by #136
Closed

Migrate the website from Python to Rust #132

Guileas opened this issue Oct 14, 2020 · 13 comments · Fixed by #136
Assignees

Comments

@Guileas
Copy link

Guileas commented Oct 14, 2020

I'm currently working on a new version of the phpMyAdmin website with @williamdes.
Python will be replaced by Rust using Rocket framework but all the UI and HTML will stay the same.
I will fix the issue #131 afterwards, you can assign it to me.
This will fix all the current vulnerability issue with the current Django backend

@williamdes
Copy link
Member

cc @ibennetch @MauricioFauth

@MauricioFauth
Copy link
Member

Why not use PHP for a new version of the website?

@MauricioFauth
Copy link
Member

MauricioFauth commented Oct 14, 2020

I think if we want to change the language, it makes much more sense to switch to PHP instead of Rust.

@Guileas
Copy link
Author

Guileas commented Oct 15, 2020

why not?
Rust is know to be much more fast and code safe than PHP

@AdrianoCahete
Copy link

5 cents from outside: Why not a static generator, like Nuxt?

@Guileas
Copy link
Author

Guileas commented Oct 16, 2020

I'm personally not interested in using a Node-based technology but Nuxt could be a good choice.
I think Rust is as good as Nuxt (if not better) and will make a great website.
If you don't think so it's ok but the current website need's to be review (python is already in version 3.9 and django in 3.1).
Let me know if you are interested in giving a chance to Rust, I've already forked the project so I'm gonna work on it.

@AdrianoCahete
Copy link

AdrianoCahete commented Oct 16, 2020

Although Nuxt is node-based, it generates a HTML/JS/CSS static assets to be hosted on any platform (like the Netlify Free Tier, for example). I really don't know how Rust based website can be hosted or what it needs to run, but I'm not against it at all, neither know how much time/work did you put in that branch.

In parallel, I'm creating a new proposal for UI so you can do this update and we go with the UI update at the same time.

But both decisions are for the project team (that I'm not part of).

@Guileas
Copy link
Author

Guileas commented Oct 17, 2020

To deploy a Rust website, you just need to use Cargo command (Cargo is the Rust package manager) and some Nginx configurations you can also use Docker it's pretty easy.

I'm ok with the UI update I think it's a good idea to redesign it!

Your right, let the team decide

@MauricioFauth
Copy link
Member

MauricioFauth commented Oct 22, 2020

Rust is know to be much more fast and code safe than PHP

This is true if you are comparing to PHP 5, but not so much for PHP 7 and PHP 8. I think the performance and safety of the code that you write are more relevant.

I think if we want to change the language, it makes much more sense to switch to PHP instead of Rust.

If we decide to move away from Python, rewriting in PHP makes more sense, because, besides the website, everything we build is written mainly in PHP. So using PHP will reduce the friction of using different languages, easing the contributions.

@ibennetch
Copy link
Member

I think personally Nuxt is the least desirable option that was presented; continuing with Python, switching to PHP, and switching to Rust are roughly in my order of preference — but they're all pretty good options. Having people willing to do the work for Rust makes it somewhat desirable, but I like how the Django backend we have now handles a lot of the harder work for us.

@vimalMK
Copy link

vimalMK commented Oct 26, 2022

The topic caught my interest. When the works starts please pull me in. sounds interesting.

@williamdes
Copy link
Member

williamdes commented Oct 26, 2022

I think we should reset the subject, two years later Rust is getting everywhere and performance+consumption is perfect.
The learning curve is not easy but once it works you have nothing more to do (kind of)

Who votes in favor of dropping the Python website for the same website in Rust?
To be clear this does not mean any UI change. I am unable to fix updates on this website because it uses Python and dependencies that are not up to date and It seems like nobody manages to update them anyway. (Ref #136)

cc @phpmyadmin/developers

@vimalMK
Copy link

vimalMK commented Oct 27, 2022

+1 👍

Probably I am early to vote for this. But it will be a good move to Rust.

Learning curve is expected. I think its Rocket Framework https://rocket.rs/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants