Upgrade website to be compatible with Python3 #136
Conversation
|
Remaining items to do:
|
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Ready to be merged ? |
williamdes
force-pushed
the
python3
branch
2 times, most recently
from
9126e6c
to
dd8a1da
Compare
Tests are still failing: https://github.com/phpmyadmin/website/runs/1835861700#step:8:7 |
|
Hi, any update on this? |
MauricioFauth
force-pushed
the
python3
branch
2 times, most recently
from
bec3d2e
to
1c52cd4
Compare
|
The tests are broken since a180276. |
MauricioFauth
force-pushed
the
python3
branch
3 times, most recently
from
17110d9
to
7284153
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #136 +/- ##
==========================================
+ Coverage 63.61% 63.95% +0.33%
==========================================
Files 65 68 +3
Lines 1432 1426 -6
==========================================
+ Hits 911 912 +1
+ Misses 521 514 -7 |
|
@ibennetch @williamdes Tests are now passing on this PR. I think it can be merged if the server has Python 3.7 installed (as it's the last version support by Django 1.11). This way we can work on upgrading the Django version. |
|
Great, thanks for the work on this. Yes, 3.7 is installed, although not the
default when calling /bin/env python so it might need a tweak to update for
that
I'm not merging it right now because I don't have time tonight to fix
anything if there are migration problems, so I'll hold off until I (or
someone else) has time to devote to that, but I think it's ready to merge.
|
Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
…of course throws an error) Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
https://docs.djangoproject.com/en/1.11/topics/python3/#str-and-unicode-methods Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
The server is now upgraded to Debian bookworm, and here is the sed commands to monkey patch the outdated Django vendor: d4b4171 |
This series of commits should upgrade the website to Python3 compatibility.
It doesn't automatically upgrade the software running on the server, so before merging we should be ready to perform the appropriate software installation/reconfiguration. I believe that merging this while still on Python2 will break the site. As a result, this is currently a draft pull request.
Closes: #132