Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Custom Error Pages #30

Open
nijel opened this issue Sep 16, 2016 · 5 comments
Open

Implement Custom Error Pages #30

nijel opened this issue Sep 16, 2016 · 5 comments

Comments

@nijel
Copy link
Contributor

nijel commented Sep 16, 2016

that will be used instead of nginx default error pages:
https://www.phpmyadmin.net/static/A

Note: The custom error page is already there, it just needs to be used for static files as well.

@AdrianoCahete
Copy link

AdrianoCahete commented Nov 3, 2020

It's already handling, just throwing an error for some reason:

handler404 = 'pmaweb.views.notfound'

website/pmaweb/views.py

Lines 86 to 92 in 35a9f3f

def notfound(request):
return render(
request,
'404.html',
{'title': 'Page Not Found'},
status=404
)

Trying to fix on my PR, but since I never had worked with Python for web before, I may not fix it.

Yep, I read all the issues.

@vimalMK
Copy link

vimalMK commented Nov 2, 2022

@nijel @williamdes Can I work on this, if its still required?

@williamdes
Copy link
Member

@nijel @williamdes Can I work on this, if its still required?

Sure, do you know enough python to finish #136?

@vimalMK
Copy link

vimalMK commented Nov 2, 2022

@williamdes Thank you and yes I can try #136 .

@vimalMK
Copy link

vimalMK commented Nov 3, 2022

@williamdes can you please confirm/share what the production settings.py looks like?

the path will be: phpmyadmin-website\pmaweb\settings.py

Important changes in the settings.py which is also in PR

DEBUG = FALSE
COMPRESS_ENABLED = os.environ.get('COMPRESS_ENABLED', False)

vimalMK added a commit to vimalMK/phpmyadmin-website that referenced this issue Nov 3, 2022
Signed-off-by: Vimal K <vimalinfo10@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants