Merge pull request #597 from Deuchnord/feat/check-class-exists-before…

…-prophesizing feat: add control over class/interface existence before trying to prophesize it
phpspec · Jun 21, 2023 · e0ae099 · e0ae099
2 parents 8168610 + 2dfa9d7
commit e0ae099
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 5 deletions.
diff --git a/spec/Prophecy/ProphetSpec.php b/spec/Prophecy/ProphetSpec.php
@@ -78,4 +78,17 @@ function it_exposes_doubler_through_getter($doubler)
     {
         $this->getDoubler()->shouldReturn($doubler);
     }
+
+    function it_throws_ClassNotFound_if_class_to_prophesize_does_not_exist()
+    {
+        $this->shouldThrow('Prophecy\Exception\Doubler\ClassNotFoundException')
+            ->duringProphesize('This\ClassOrInterface\Does\Not\Exist');
+
+    }
+
+    function it_does_not_throw_when_creating_void_mock()
+    {
+        $this->shouldNotThrow()
+            ->duringProphesize();
+    }
 }
diff --git a/src/Prophecy/Prophet.php b/src/Prophecy/Prophet.php
@@ -15,6 +15,7 @@
 use Prophecy\Doubler\Doubler;
 use Prophecy\Doubler\LazyDouble;
 use Prophecy\Doubler\ClassPatch;
+use Prophecy\Exception\Doubler\ClassNotFoundException;
 use Prophecy\Prophecy\ObjectProphecy;
 use Prophecy\Prophecy\RevealerInterface;
 use Prophecy\Prophecy\Revealer;
@@ -83,12 +84,19 @@ public function prophesize($classOrInterface = null)
             $this->revealer
         );
 
-        if ($classOrInterface && class_exists($classOrInterface)) {
-            return $prophecy->willExtend($classOrInterface);
-        }
+        if ($classOrInterface) {
+            if (class_exists($classOrInterface)) {
+                return $prophecy->willExtend($classOrInterface);
+            }
+
+            if (interface_exists($classOrInterface)) {
+                return $prophecy->willImplement($classOrInterface);
+            }
 
-        if ($classOrInterface && interface_exists($classOrInterface)) {
-            return $prophecy->willImplement($classOrInterface);
+            throw new ClassNotFoundException(sprintf(
+                'Cannot prophesize class %s, because it cannot be found.',
+                $classOrInterface
+            ), $classOrInterface);
         }
 
         return $prophecy;