Fix installing in path containing spaces #94
Conversation
Installing to any directory with spaces in the path failed because of GEM_HOME and GEM_PATH having not enough quotes around them and ruby failing to parse the options from RUBYOPT when the -r option had spaces in it. Fixed this by adding the necessary escapes to add doublequotes around the env variables and moved restore_environment.rb to the lib/ruby/site_ruby/ folder, which is in the ruby load path, so the -r option doesn't need to reference the full absolute path. Fixes phusion#38.
…ath with spaces traveling-ruby failed to run when installed in a directory with spaces in the path. (See: phusion/traveling-ruby#38) Worked around this by adding the necessary escapes for quotes with `sed` in the build script. Also opened a PR with a proper upstream fix: phusion/traveling-ruby#94
…ath with spaces traveling-ruby failed to run when installed in a directory with spaces in the path. (See: phusion/traveling-ruby#38) Worked around this by adding the necessary escapes for quotes with `sed` in the build script. Also opened a PR with a proper upstream fix: phusion/traveling-ruby#94
|
Is there any chance that this could be merged and released? It would be useful to the pact project, as we use travelling ruby quite a bit. |
|
@TimothyJones This pull request looks solid. I'll give making a new release a try. It's been a while since I've touched this and both the macOS and the Linux ecosystem have changed, so it'll take a while for me to resetup a development environment. |
|
After days of work, I've finally gotten it to build properly on macOS 10.15. Because the ecosystem has changed so much, I'm forced to upgrade to Ruby 2.4, and to raise the minimum supported macOS version to 10.14. Next up will be updating Linux support. The main problem there is that CentOS 5 has reached end-of-life, so something must be done about that. I'm thinking about using this opportunity to switch to Holy Build Box, but I'll need to verify whether there are any open issues. |
|
This is very very much appreciated! Thank you! I think the Ruby upgrade might actually fix another issue we were having on windows, so that's an added bonus! |
|
Correction, macOS gave me more trouble than I thought. Not only did I have to fight System Integrity Protection, various dependencies needed tweaking. Luckily I've been able to solve those troubles. I've documented some of the challenges I've gone through: |
|
I've released a couple of new Holy Build Box versions which solved various issues and modernizes the build environment. With that over, it's time to get back to updating the Linux version of Traveling Ruby. |
|
The Linux and Windows versions have been updated too. The next version of Traveling Ruby is now releasable. I'll merge in this PR. Thanks @fson. |
Installing to any directory with spaces in the path failed because of GEM_HOME and GEM_PATH having not enough quotes around them and ruby failing to parse the options from RUBYOPT when the -r option had spaces in it. Fixed this by adding the necessary escapes to add doublequotes around the env variables and moved restore_environment.rb to the lib/ruby/site_ruby/ folder, which is in the ruby load path, so the -r option doesn't need to reference the full absolute path. Closes #38. Contributed by Ville Immonen (@fson) in #94.
|
@TimothyJones 20210206 is now released. |
|
You are amazing! Thank you so much. Especially after being down with covid, wow. Wishing you a safe recovery.
We’ll check it out as soon as we can!
…Sent from my mobile
On 5 Feb 2021, at 10:10 pm, Hongli Lai ***@***.***> wrote:
@TimothyJones 20210206 is now released.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Installing to any directory with spaces in the path failed because of
GEM_HOMEandGEM_PATHhaving not enough quotes around them and ruby failing to parse the options fromRUBYOPTwhen the-roption had spaces in it.Fixed this by adding the necessary escapes to add doublequotes around the env variables and moved
restore_environment.rbto thelib/ruby/site_ruby/folder, which is in the ruby load path, so the-roption doesn't need to reference the full absolute path.Fixes #38.