-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
False indel-derived offtargets #67
Comments
Hi @thomas-davis, Thank you for bringing this issue to our attention. Could you kindly share the code you’re using to add variants to the sequences? This will help us replicate the behavior in CRISPRme using a public spacer, so we can investigate if the issue persists in a broader context. Best, |
Hi @thomas-davis, I am writing to follow up on the status of the scripts that were being adapted to utilize public guides for reproducing the unexpected behaviors observed in CRISPRme. We believe that having access to these scripts could be instrumental in helping us identify the underlying causes of the inconsistencies we have encountered. Any updates or insights you could provide would be greatly appreciated, as they may help expedite our understanding and resolution of these issues. Additionally, I would like to let you know that version 2.1.1 has been deprecated, as it contains a known bug that affects the correct reporting of targets generated by indels. We advise using a CRISPRme v2.1.5 or greater to avoid this issue, although you reported similar issues even running this tool's version. Thank you for your time and assistance. Best, |
Hey @ManuelTgn apologies I'll get back to you as soon as I can. We were also wondering what public spacer you'd planned to use for crisprme testing, ideally wanted to run it on our end as well to test our infrastructure. It is the one listed in sg1617.txt? |
Yes, we can use that one for testing and reproducibility purposes.
Thanks!
Luca
…On Mon, Sep 16, 2024 at 12:31 PM thomas-davis ***@***.***> wrote:
Hey @ManuelTgn <https://github.com/ManuelTgn> apologies I'll get back to
you as soon as I can.
We were also wondering what public spacer you'd planned to use for
crisprme testing, ideally wanted to run it on our end as well to test our
infrastructure. It is the one listed in sg1617.txt?
—
Reply to this email directly, view it on GitHub
<#67 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIH72QUQAAHRS3TYWP3ZH3ZW4BU5AVCNFSM6AAAAABN7RE662VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJTGM4TANRRHE>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Sorry I still owe you code but side question-- we tried running sg1617 to replicate the bug and ran into error.
We were running the following with v2.1.5 of crisprme
It seems like here you guys deal with case of 'N' being present in reference genome match but not necessarily other IUPAC expanded nucleotides (like 'R') which causes crash over here |
Also here's the notebook code. Currently run on a proprietary spacer, so I can't include intermediate outputs or much detail. Once we run sg1617.txt I can link with intermediate files. |
One last comment, one of my colleagues will be taking over this correspondence. Thanks in advance for your help. |
Hi, I'll be taking over correspondence for this issue from @thomas-davis. Let me know if there's anything else that's needed from our side and thanks! |
Hi @thomas-davis and @dkuo-ttx, Thank you for sharing the details. The error log is indeed unusual, and we haven’t encountered this issue before. We will thoroughly investigate the problem and work on identifying a solution. Best, |
Hi @dkuo-ttx, We attempted to reproduce the reported error using a different PAM, such as NAA, which seems similar to what you’re working with. However, we weren't able to replicate the issue, and the run completed smoothly. Below is the exact sequence of commands we executed for testing:
I've also attached the full log files for reference: Could you please share the specific PAM sequence file you're using? There might be an issue related to that. Additionally, if the conversation may touch on any confidential information, we can switch to email to ensure everything remains secure. Best, |
Hi @ManuelTgn, Thanks for the replies and apologies for my delay in getting back to you. My colleague was more deeply engaged in this issue so thanks also for your patience as I get up to speed. Interesting that the run completed smoothly. We used this as the I think once we can get the test spacer to run, we can assess the InDel bug together. I'll send another update in the next 2-3 days. Thank you! |
Describe the bug
I suspect CRISRPme is occasionally reporting off-targets generated by indels that are False-- i.e. that are not actually generated by the reported indel
As part of an analysis, I generate oligos representing variant-containing off-target sequences with surrounding genomic context.
To do this I'm extract the reference sequence and surrounding context for off-target sites reported in crisprme, and then introducing the reported SNP into the sequence. 95-99% of the time I am able to find the reported off-target in this extracted sequence. However rarely, for some indel associated off-targets, I am unable to find a sequence that matched the reported off-target.
I can't send explicit examples unfortunately because they involve proprietary spacers, but I have observed this same bug across two versions of crisprme (v2.1.5 and v2.1.1). Is this a known bug? What other information would be helpful in tracking this down? I'm happy to disclose the code I'm using to add variants to the extracted sequence. If you have outputs for a public spacer I can take a look at whether the same bug is present and give concrete examples. The bug is preventing us from being able to use crisprme for our application.
To Reproduce
Ran crisprme via the command line using HG38, 1000G + HGDP.
Spacer sequences
I can't disclose this, apologies. Observed across two difference spacers. If need be I can try to reproduce with a public spacer.
Cas protein
Also cannot disclose this. Effect observed across two different CAS's
PAM
Also cannot disclose this. Effect observed across two different PAMs
Genome
HG38
Variants dataset (OPTIONAL)
HGDP + 1000G
Thresholds
Mismatches: 6
DNA Bulges: 2
RNA Bulges: 2
Expected behavior
Indels should generate the expected off-target sequence
Screenshots
If running CRISPRme via website, add screenshots to help explain your problem.
Environment (please complete the following information, ONLY applicable if running CRISPRme via command line):
Thank you in advance for your help!
The text was updated successfully, but these errors were encountered: