Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

lightning: cherry-pick some PRs #1458

Merged
merged 5 commits into from
Jan 25, 2022
Merged

lightning: cherry-pick some PRs #1458

merged 5 commits into from
Jan 25, 2022

Conversation

glorv
Copy link
Collaborator

@glorv glorv commented Jan 24, 2022 •
edited
Loading

What problem does this PR solve?

cherry-pick pingcap/tidb#27769 and pingcap/tidb#30393

also cherry-pick pingcap/tidb#29730 to pass integration test

also partically cherry-pick pingcap/tidb#29062 to fix some unstable integration tests

What is changed and how it works?

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release note

  • Fix the bug that tidb-lightning can only read at most 1000 files from gcs storage.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 24, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • YuJuncen
  • gozssky

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@glorv glorv changed the title cherry-pick some PRs into v5.1 and v4.0 lightning: cherry-pick some PRs into v5.1 and v4.0 Jan 24, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 LGTM1 label Jan 24, 2022
@glorv
Copy link
Collaborator Author

glorv commented Jan 24, 2022

/run-integration-test

@glorv glorv changed the title lightning: cherry-pick some PRs into v5.1 and v4.0 lightning: cherry-pick some PRs Jan 24, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 LGTM2 and removed status/LGT1 LGTM1 labels Jan 24, 2022
@glorv
Copy link
Collaborator Author

glorv commented Jan 24, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 9a534dc

@glorv
Copy link
Collaborator Author

glorv commented Jan 24, 2022

/run-integration-test

@YuJuncen
Copy link
Collaborator

/run-integration-tests

@YuJuncen
Copy link
Collaborator

/run-integration-test

@glorv
Copy link
Collaborator Author

glorv commented Jan 24, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: d8ff821

@glorv
Copy link
Collaborator Author

glorv commented Jan 25, 2022

/run-integration-test

@glorv glorv merged commit ec59c7b into pingcap:master Jan 25, 2022
@glorv glorv deleted the cp-prs branch January 25, 2022 03:42
ti-chi-bot pushed a commit to ti-chi-bot/br that referenced this pull request Jan 25, 2022
@glorv @ti-chi-bot
This is an automated cherry-pick of pingcap#1458
5a18f31 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Jan 25, 2022
Closed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #1459.

ti-chi-bot pushed a commit to ti-chi-bot/br that referenced this pull request Jan 25, 2022
@glorv @ti-chi-bot
This is an automated cherry-pick of pingcap#1458
3e281c7 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Jan 25, 2022
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #1460.

ti-chi-bot pushed a commit to ti-chi-bot/br that referenced this pull request Jan 25, 2022
@glorv @ti-chi-bot
This is an automated cherry-pick of pingcap#1458
03fc3b3 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Jan 25, 2022
Closed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #1461.

ti-chi-bot added a commit that referenced this pull request Feb 8, 2022
@ti-chi-bot
lightning: cherry-pick some PRs (#1458) (#1460)
0ef10e6
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sleepymole sleepymole sleepymole approved these changes

@YuJuncen YuJuncen YuJuncen approved these changes

@kennytm kennytm Awaiting requested review from kennytm

@3pointer 3pointer Awaiting requested review from 3pointer

Assignees
No one assigned
Labels
needs-cherry-pick-release-4.0 needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 size/L status/can-merge status/LGT2 LGTM2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@glorv @ti-chi-bot @YuJuncen @sleepymole