Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: change the specification of "TIDB_INLJ" #1000

Merged
merged 2 commits into from
Nov 22, 2018
Merged

sql: change the specification of "TIDB_INLJ" #1000

merged 2 commits into from
Nov 22, 2018

Conversation

zz-jason
Copy link
Member

After pingcap/tidb#8298, the join hint TIDB_INLJ specifies the inner table in the join operator. This PR updates the document about this behavior change.

@zz-jason
Copy link
Member Author

@winoros @XuHuaiyu @lilin90 PTAL

lilin90
lilin90 reviewed Nov 21, 2018
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you please help update the format (space)? Thanks!

sql/tidb-specific.md Outdated Show resolved Hide resolved
@lilin90 @zz-jason
Update sql/tidb-specific.md
244bde5 
Co-Authored-By: zz-jason <zjsariel@gmail.com>
lilin90
lilin90 reviewed Nov 21, 2018
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 21, 2018
winoros
winoros reviewed Nov 22, 2018
View reviewed changes
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zz-jason zz-jason merged commit 3aa8ba5 into pingcap:master Nov 22, 2018
@zz-jason zz-jason deleted the dev/inlj_inner branch November 22, 2018 08:38
lilin90 added a commit to lilin90/docs that referenced this pull request Nov 22, 2018
@lilin90
sql: change the specification of "TIDB_INLJ"
4338112 
Via: pingcap/docs-cn#1000
@lilin90 lilin90 mentioned this pull request Nov 22, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winoros winoros winoros left review comments

@lilin90 lilin90 lilin90 approved these changes

Assignees
No one assigned
Labels
status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zz-jason @winoros @lilin90