Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slow-query: add Warnings field to slow log and the slow query table #12638

Merged
merged 4 commits into from
Feb 10, 2023
Merged

slow-query: add Warnings field to slow log and the slow query table #12638

merged 4 commits into from
Feb 10, 2023

Conversation

time-and-fate
Copy link
Member

@time-and-fate time-and-fate commented Jan 11, 2023 •
edited by Oreoxmt
Loading

What is changed, added or deleted? (Required)

Starting from TiDB v6.6.0, the Warnings field is added in slow query log

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.4 (TiDB 6.4 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 11, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Oreoxmt

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 11, 2023
@Oreoxmt Oreoxmt added translation/doing This PR’s assignee is translating this PR. and removed missing-translation-status This PR does not have translation status info. labels Jan 11, 2023
@Oreoxmt Oreoxmt self-assigned this Jan 11, 2023
@Oreoxmt Oreoxmt added the v6.6 label Jan 11, 2023
Oreoxmt
Oreoxmt reviewed Jan 11, 2023
View reviewed changes
identify-slow-queries.md Outdated Show resolved Hide resolved
@Oreoxmt Oreoxmt self-requested a review January 11, 2023 06:53
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Jan 11, 2023

@time-and-fate Could you please invite a tech reviewer? Thanks!

@time-and-fate @Oreoxmt
Update identify-slow-queries.md
a4b2c35 
Co-authored-by: Aolin <aolinz@outlook.com>
@time-and-fate
Copy link
Member Author

/cc xuyifangreeneyes

@Oreoxmt Oreoxmt mentioned this pull request Jan 20, 2023
Merged
14 tasks
@Oreoxmt Oreoxmt added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jan 20, 2023
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Jan 28, 2023

@xuyifangreeneyes PTAL

@Oreoxmt Oreoxmt added the area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. label Jan 29, 2023
Oreoxmt
Oreoxmt approved these changes Feb 1, 2023
View reviewed changes
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 1, 2023
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Feb 1, 2023

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 1, 2023
shichun-0415
shichun-0415 approved these changes Feb 1, 2023
View reviewed changes
Copy link
Contributor

@shichun-0415 shichun-0415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@Oreoxmt @shichun-0415
Apply suggestions from code review
69e182f 
Co-authored-by: shichun-0415 <89768198+shichun-0415@users.noreply.github.com>
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Feb 10, 2023

/verify
/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 69e182f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 10, 2023
@ti-chi-bot ti-chi-bot merged commit 7608db3 into pingcap:master Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xuyifangreeneyes xuyifangreeneyes xuyifangreeneyes approved these changes

@Oreoxmt Oreoxmt Oreoxmt approved these changes

@shichun-0415 shichun-0415 shichun-0415 approved these changes

Assignees

@Oreoxmt Oreoxmt

Labels
area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v6.6
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@time-and-fate @ti-chi-bot @Oreoxmt @xuyifangreeneyes @shichun-0415