Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add persistent statements summary #12677

Merged
merged 13 commits into from
Feb 10, 2023
Merged

Add persistent statements summary #12677

merged 13 commits into from
Feb 10, 2023

Conversation

mornyx
Copy link
Contributor

@mornyx mornyx commented Jan 16, 2023 •
edited
Loading

What is changed, added or deleted? (Required)

Add documentation for a new experimental feature: Persistent Statements Summary.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.4 (TiDB 6.4 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@mornyx
Add persistent statements summary
9acaa71 
Signed-off-by: mornyx <mornyx.z@gmail.com>
@mornyx
Fix description
9dbd397 
Signed-off-by: mornyx <mornyx.z@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 16, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • shichun-0415

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 16, 2023
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 16, 2023
@shichun-0415 shichun-0415 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. area/diagnosis Indicates that the Issue or PR belongs to the area of diagnosis and monitoring. v6.6 and removed missing-translation-status This PR does not have translation status info. labels Jan 16, 2023
@shichun-0415 shichun-0415 requested review from shichun-0415 and removed request for qiancai January 16, 2023 08:16
@shichun-0415 shichun-0415 mentioned this pull request Jan 17, 2023
Merged
14 tasks
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 21, 2023
@mornyx mornyx mentioned this pull request Jan 29, 2023
Merged
12 tasks
@mornyx
Rename configurations
24fb43b 
Signed-off-by: mornyx <mornyx.z@gmail.com>
@mornyx mornyx marked this pull request as ready for review January 30, 2023 08:00
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 30, 2023
@mornyx
Merge branch 'master' into stmtsummary
897d403 
Signed-off-by: mornyx <mornyx.z@gmail.com>
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 31, 2023
@shichun-0415
Copy link
Contributor

/status LGT1

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 2, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 3, 2023
Oreoxmt
Oreoxmt reviewed Feb 3, 2023
View reviewed changes
statement-summary-tables.md Outdated Show resolved Hide resolved
statement-summary-tables.md Outdated Show resolved Hide resolved
statement-summary-tables.md Outdated Show resolved Hide resolved
tidb-configuration-file.md Outdated Show resolved Hide resolved
tidb-configuration-file.md Outdated Show resolved Hide resolved
tidb-configuration-file.md Outdated Show resolved Hide resolved
tidb-configuration-file.md Show resolved Hide resolved
tidb-configuration-file.md Outdated Show resolved Hide resolved
tidb-configuration-file.md Outdated Show resolved Hide resolved
tidb-configuration-file.md Show resolved Hide resolved
@shichun-0415 @Oreoxmt
Apply suggestions from code review
fd85267 
Co-authored-by: Aolin <aolinz@outlook.com>
Oreoxmt
Oreoxmt approved these changes Feb 6, 2023
View reviewed changes
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Oreoxmt
Oreoxmt reviewed Feb 7, 2023
View reviewed changes
statement-summary-tables.md Outdated Show resolved Hide resolved
statement-summary-tables.md Outdated Show resolved Hide resolved
statement-summary-tables.md Outdated Show resolved Hide resolved
mornyx and others added 2 commits February 7, 2023 18:54
@mornyx @Oreoxmt
Apply suggestions from code review
1e83c35 
Co-authored-by: Aolin <aolinz@outlook.com>
@mornyx
add description
928b17e 
Signed-off-by: mornyx <mornyx.z@gmail.com>
Oreoxmt
Oreoxmt reviewed Feb 8, 2023
View reviewed changes
statement-summary-tables.md Outdated Show resolved Hide resolved
Oreoxmt
Oreoxmt approved these changes Feb 8, 2023
View reviewed changes
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@shichun-0415 @Oreoxmt
Update statement-summary-tables.md
95d67b6 
Co-authored-by: Aolin <aolinz@outlook.com>
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Feb 10, 2023

/verify

@TomShawn TomShawn closed this Feb 10, 2023
@TomShawn TomShawn reopened this Feb 10, 2023
@shichun-0415
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 95d67b6

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 10, 2023
@ti-chi-bot ti-chi-bot merged commit 0bc10e1 into pingcap:master Feb 10, 2023
@mornyx mornyx deleted the stmtsummary branch February 13, 2023 08:53
@mornyx mornyx mentioned this pull request Feb 15, 2023
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shichun-0415 shichun-0415 shichun-0415 approved these changes

@zhongzc zhongzc zhongzc approved these changes

@Oreoxmt Oreoxmt Oreoxmt approved these changes

Assignees

@mornyx mornyx

@shichun-0415 shichun-0415

Labels
area/diagnosis Indicates that the Issue or PR belongs to the area of diagnosis and monitoring. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v6.6
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mornyx @ti-chi-bot @shichun-0415 @Oreoxmt @zhongzc @TomShawn