Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added REORGANIZE PARTITION as a new feature #11385

Merged
merged 41 commits into from
Mar 27, 2023

Conversation

mjonss
Copy link
Contributor

@mjonss mjonss commented Nov 20, 2022

What is changed, added or deleted? (Required)

Updated documentation for the new feature REORGANIZE PARTITION

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v6.5 (TiDB 6.5 versions)
  • v6.4 (TiDB 6.4 versions)
  • v6.3 (TiDB 6.3 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 20, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hfxsd
  • qiancai

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 20, 2022
@qiancai qiancai added v6.5 This PR/issue applies to TiDB v6.5. translation/doing This PR's assignee is translating this PR. labels Nov 21, 2022
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Nov 21, 2022
@qiancai qiancai added the area/bigdata Indicates that the Issue or PR belongs to the area of TiFlash, TiSpark, and OLAP. label Nov 21, 2022
@qiancai qiancai self-assigned this Nov 21, 2022
@qiancai qiancai requested review from moyun and qiancai and removed request for shichun-0415 November 21, 2022 01:29
moyun
moyun previously approved these changes Nov 21, 2022
Copy link

@moyun moyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@moyun moyun dismissed their stale review November 21, 2022 03:22

Isn’t it a GA function?

Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mjonss I've made some comments. PTAL. Thanks.

partitioned-table.md Outdated Show resolved Hide resolved
partitioned-table.md Outdated Show resolved Hide resolved
partitioned-table.md Show resolved Hide resolved
partitioned-table.md Show resolved Hide resolved
partitioned-table.md Outdated Show resolved Hide resolved
partitioned-table.md Outdated Show resolved Hide resolved
partitioned-table.md Outdated Show resolved Hide resolved
partitioned-table.md Outdated Show resolved Hide resolved
partitioned-table.md Outdated Show resolved Hide resolved
partitioned-table.md Outdated Show resolved Hide resolved
@mjonss mjonss changed the title Added REORGANIZE PARTITION as experimental feature Added REORGANIZE PARTITION as a new feature Nov 21, 2022
mjonss and others added 11 commits November 21, 2022 23:51
Co-authored-by: Grace Cai <qqzczy@126.com>
Co-authored-by: Grace Cai <qqzczy@126.com>
Co-authored-by: Grace Cai <qqzczy@126.com>
Co-authored-by: Grace Cai <qqzczy@126.com>
Co-authored-by: Grace Cai <qqzczy@126.com>
Co-authored-by: Grace Cai <qqzczy@126.com>
Co-authored-by: Grace Cai <qqzczy@126.com>
Co-authored-by: Grace Cai <qqzczy@126.com>
Co-authored-by: Grace Cai <qqzczy@126.com>
Co-authored-by: Grace Cai <qqzczy@126.com>
partitioned-table.md Show resolved Hide resolved
partitioned-table.md Outdated Show resolved Hide resolved
partitioned-table.md Outdated Show resolved Hide resolved
partitioned-table.md Outdated Show resolved Hide resolved
partitioned-table.md Outdated Show resolved Hide resolved
partitioned-table.md Outdated Show resolved Hide resolved
Co-authored-by: xixirangrang <hfxsd@hotmail.com>
@qiancai qiancai added v7.0 and removed v6.6 labels Feb 3, 2023
partitioned-table.md Outdated Show resolved Hide resolved
partitioned-table.md Outdated Show resolved Hide resolved
mjonss and others added 2 commits March 21, 2023 11:40
Co-authored-by: bb7133 <bb7133@gmail.com>
Co-authored-by: bb7133 <bb7133@gmail.com>
partitioned-table.md Outdated Show resolved Hide resolved
partitioned-table.md Outdated Show resolved Hide resolved
partitioned-table.md Outdated Show resolved Hide resolved
partitioned-table.md Outdated Show resolved Hide resolved
partitioned-table.md Outdated Show resolved Hide resolved
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 23, 2023
Copy link
Collaborator

@hfxsd hfxsd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

mysql-compatibility.md Outdated Show resolved Hide resolved
partitioned-table.md Outdated Show resolved Hide resolved
mysql-compatibility.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 24, 2023
Co-authored-by: xixirangrang <hfxsd@hotmail.com>
mysql-compatibility.md Outdated Show resolved Hide resolved
mysql-compatibility.md Outdated Show resolved Hide resolved
@qiancai
Copy link
Collaborator

qiancai commented Mar 27, 2023

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 3a224fa

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 27, 2023
@ti-chi-bot ti-chi-bot merged commit 99414aa into pingcap:master Mar 27, 2023
@mjonss mjonss deleted the reorg-partition branch March 27, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/bigdata Indicates that the Issue or PR belongs to the area of TiFlash, TiSpark, and OLAP. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants