Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add doc for experimental variable tidb_store_batch_size #11562

Merged
merged 7 commits into from
Dec 9, 2022
Merged

add doc for experimental variable tidb_store_batch_size #11562

merged 7 commits into from
Dec 9, 2022

Conversation

you06
Copy link
Contributor

@you06 you06 commented Dec 8, 2022

Signed-off-by: you06 you1474600@gmail.com

First-time contributors' checklist

What is changed, added or deleted? (Required)

ref: pingcap/tidb#39361

Document the experimental feature tidb_store_batch_size.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.4 (TiDB 6.4 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@you06
add tidb_store_batch_size variable
ad35ee5 
Signed-off-by: you06 <you1474600@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 8, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Oreoxmt
  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added contribution This PR is from a community contributor. missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 8, 2022
@Oreoxmt Oreoxmt self-requested a review December 8, 2022 06:17
@Oreoxmt Oreoxmt added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v6.5 This PR/issue applies to TiDB v6.5. labels Dec 8, 2022
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Dec 8, 2022
@Oreoxmt Oreoxmt added missing-translation-status This PR does not have translation status info. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. for-release This PR relates to a TiDB release but does not have a tracked feature. and removed missing-translation-status This PR does not have translation status info. labels Dec 8, 2022
Oreoxmt
Oreoxmt approved these changes Dec 8, 2022
View reviewed changes
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

system-variables.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 8, 2022
you06 and others added 3 commits December 8, 2022 14:36
@you06 @Oreoxmt
Update system-variables.md
ce8fa0d 
Co-authored-by: Aolin <aolinz@outlook.com>
@you06
more notice
6c2bb76 
Signed-off-by: you06 <you1474600@gmail.com>
@you06
not an experimental variable'
fc5e486 
Signed-off-by: you06 <you1474600@gmail.com>
TomShawn
TomShawn reviewed Dec 8, 2022
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
@you06 @TomShawn
Update system-variables.md
d4d9034 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
TomShawn
TomShawn approved these changes Dec 8, 2022
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comment

system-variables.md Outdated Show resolved Hide resolved
system-variables.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 8, 2022
you06 and others added 2 commits December 8, 2022 16:33
@you06 @TomShawn
Update system-variables.md
3daf2db 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@you06 @TomShawn
Update system-variables.md
75a3f05 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@Oreoxmt Oreoxmt removed the request for review from shichun-0415 December 9, 2022 04:00
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Dec 9, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 75a3f05

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 9, 2022
@ti-chi-bot ti-chi-bot merged commit 7e69f95 into pingcap:master Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn approved these changes

@Oreoxmt Oreoxmt Oreoxmt approved these changes

Assignees

@Oreoxmt Oreoxmt

Labels
contribution This PR is from a community contributor. for-release This PR relates to a TiDB release but does not have a tracked feature. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v6.5 This PR/issue applies to TiDB v6.5.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@you06 @ti-chi-bot @Oreoxmt @TomShawn