Skip to content
This repository has been archived by the owner on Aug 21, 2023. It is now read-only.

sql: fix pick up possible field (tidb#29399) #399

Merged
merged 2 commits into from
Dec 21, 2021

Conversation

lichunzhu
Copy link
Contributor

@lichunzhu lichunzhu commented Dec 20, 2021

cherry-pick pingcap/tidb#29386 to release-5.0

What problem does this PR solve?

close pingcap/tidb#29386
Issue Number: close #xxx

Problem Summary:

What is changed and how it works?

Fix dumpling pick up possible field function by always pick the index whose 'seqInIndex' is "1".

Check List

Tests

  • Unit test
  • Integration test

Release note

fix the bug that dumpling gets very slow when dumping composite primary/unique key tables.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 20, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • glorv

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@lichunzhu
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 7f237df

@ti-chi-bot ti-chi-bot merged commit e749ae3 into pingcap:release-5.0 Dec 21, 2021
@lichunzhu lichunzhu deleted the cherryPickTiDB29399to50 branch December 21, 2021 02:50
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #400.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #401.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #402.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants