Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate test-infra to testify for expression/constant_propagation_test.go #28853

Closed
Tracked by #26855
tisonkun opened this issue Oct 15, 2021 · 3 comments · Fixed by #30430
Closed
Tracked by #26855

migrate test-infra to testify for expression/constant_propagation_test.go #28853

tisonkun opened this issue Oct 15, 2021 · 3 comments · Fixed by #30430
Assignees
@tisonkun
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@tisonkun
Copy link
Contributor

No description provided.

@tisonkun tisonkun mentioned this issue Oct 15, 2021
Closed
57 tasks
@tisonkun tisonkun added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Oct 15, 2021
@tongtongyin
Copy link
Contributor

/assign

@tisonkun
Copy link
Contributor Author

tisonkun commented Dec 4, 2021

@tongtongyin for handling the testdata part, you can take a look at #30407. Other changes seem trivial.

tisonkun added a commit to tisonkun/tidb that referenced this issue Dec 6, 2021
@tisonkun
expression: migrate test-infra to testify for constant_propagation_te…
62d2768 
…st.go

This closes pingcap#28853.

Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
Copy link
Contributor Author

tisonkun commented Dec 6, 2021

I'll take over this.

@tisonkun tisonkun assigned tisonkun and unassigned tongtongyin Dec 6, 2021
@tisonkun tisonkun mentioned this issue Dec 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tisonkun tisonkun

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

expression: migrate test-infra to testify for constant_propagation_test.go tisonkun/tidb
2 participants
@tisonkun @tongtongyin