Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor the implementation of HashJoin to solve the false sharing problem #39061

Closed
XuHuaiyu opened this issue Nov 10, 2022 · 1 comment
Closed

refactor the implementation of HashJoin to solve the false sharing problem #39061

XuHuaiyu opened this issue Nov 10, 2022 · 1 comment
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@XuHuaiyu
Copy link
Contributor

Enhancement

We've found many false sharing problems in HashJoin:

Split the HashJoin into build/probe workers to fix this problem is more elegant
@XuHuaiyu XuHuaiyu added the type/enhancement The issue or PR belongs to an enhancement. label Nov 10, 2022
@XuHuaiyu XuHuaiyu mentioned this issue Nov 10, 2022
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this issue Nov 11, 2022
@XuHuaiyu
executor: split hashjoin into workers(part1) (#39063)
42ff5e6 
ref #39061
@XuHuaiyu XuHuaiyu mentioned this issue Nov 11, 2022
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this issue Nov 11, 2022
@XuHuaiyu
executor: split hashjoin into workers(part2) (#39079)
b5e1f7a 
ref #39061
@XuHuaiyu XuHuaiyu mentioned this issue Nov 11, 2022
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this issue Nov 15, 2022
@XuHuaiyu
executor: split hashjoin part3 (#39089)
bb0e8a1 
ref #39061
This was referenced Nov 15, 2022
Merged
Merged
ti-chi-bot pushed a commit that referenced this issue Nov 17, 2022
@XuHuaiyu
executor: make naaj correct (#39160)
4cfc25a 
ref #39061
ti-chi-bot pushed a commit that referenced this issue Nov 23, 2022
@XuHuaiyu
executor: split hashjoin part4 (#39155)
fee8ed7 
ref #39061
@XuHuaiyu XuHuaiyu mentioned this issue Nov 25, 2022
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this issue Nov 29, 2022
@XuHuaiyu
executor: split hashjoin part5 (#39386)
d0b72a2 
ref #39061
@XuHuaiyu XuHuaiyu mentioned this issue Dec 1, 2022
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this issue Dec 1, 2022
@XuHuaiyu
executor: refactor hashjoin part6 (#39531)
7dedfab 
ref #39061
@XuHuaiyu XuHuaiyu closed this as completed Dec 2, 2022
@XuHuaiyu
Copy link
Contributor Author

XuHuaiyu commented Dec 9, 2022 •
edited
Loading

Performance test results, you can see the improvement after this refactor. In the tidb_version column, None means without-refactor, 6.5.0 means with-refactor.
tpcds-tikv-50g gets 2.7% improvement, tpch-tikv-50g gets 3.9% improvement
20221209-133618

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@XuHuaiyu