executor: trace and control memory usage in DistSQL layer #10003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/rebuild |
alivxxx
reviewed
Apr 3, 2019
Codecov Report
@@ Coverage Diff @@
## master #10003 +/- ##
===============================================
+ Coverage 77.489% 77.5252% +0.0361%
===============================================
Files 403 403
Lines 81898 81954 +56
===============================================
+ Hits 63462 63535 +73
+ Misses 13723 13706 -17
Partials 4713 4713 |
zz-jason
reviewed
Apr 10, 2019
zz-jason
added
status/LGT2
|
/run-all-tests |
1 similar comment
|
/run-all-tests |
|
/rebuild |
|
/run-all-tests |
2 similar comments
|
/run-all-tests |
|
/run-all-tests |
|
/run-all-tests |
1 similar comment
|
/run-all-tests |
|
/run-all-tests |
|
/run-all-tests |
|
All CI problems have been fixed, PTAL~ |
alivxxx
approved these changes
Apr 12, 2019
qw4990
added a commit
to qw4990/tidb
that referenced
this pull request
Apr 19, 2019
zz-jason
pushed a commit
that referenced
this pull request
Apr 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
TiDB only traces and controls memory used in Executor layer now.
Some operators in DistSQL layer like
selectResultandcopIteratoralso have their own buffer that may use a lot of memory.Memory usage in these operators should be traced and controlled by
MemTracker.What is changed and how it works?
Introduce a new field
MemTrackerinkv.Requestto let operators in DistSQL layer use to trace and control memory usage.For simplification, this PR only support tracing DistSQL operators created by
TableReader,IndexReaderandIndexLookup.DistSQL operators created by
Analyzewill be supported by an another PR.Check List
Tests