Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: control Chunk size for Selection&Projection #10110

Merged
merged 2 commits into from
Apr 11, 2019

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Apr 10, 2019

cherry-pick for #9398

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 10, 2019
@qw4990
Copy link
Contributor Author

qw4990 commented Apr 11, 2019

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

lysu
lysu previously approved these changes Apr 11, 2019
Copy link
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lysu lysu added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 11, 2019
@qw4990
Copy link
Contributor Author

qw4990 commented Apr 11, 2019

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

3 similar comments
@qw4990
Copy link
Contributor Author

qw4990 commented Apr 11, 2019

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@qw4990
Copy link
Contributor Author

qw4990 commented Apr 11, 2019

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@qw4990
Copy link
Contributor Author

qw4990 commented Apr 11, 2019

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@qw4990
Copy link
Contributor Author

qw4990 commented Apr 11, 2019

After git rebase, all checks have passed, PTAL~ @zz-jason @lysu

@ngaut ngaut merged commit e5cfa51 into pingcap:release-2.1 Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/execution SIG execution status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants