executor: fix bad null error handling for insert statement when disabling the strict SQL mode #10161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #10161 +/- ##
===========================================
Coverage ? 77.9766%
===========================================
Files ? 407
Lines ? 83139
Branches ? 0
===========================================
Hits ? 64829
Misses ? 13511
Partials ? 4799 |
bb7133
reviewed
Apr 17, 2019
| @@ -1767,8 +1767,13 @@ func (s *testSuite) TestSQLMode(c *C) { | |||
|
|
|||
| tk.MustExec("set sql_mode = ''") | |||
| tk.MustExec("insert t values ()") | |||
| tk.MustQuery("show warnings").Check(testkit.Rows("Warning 1364 Field 'a' doesn't have a default value")) | |||
| _, err = tk.Exec("insert t values (null)") | |||
There was a problem hiding this comment.
Can we have a insert ignore t values (null) test? A warning is expected in non-strict mode
|
LGTM |
|
LGTM |
tiancaiamao
approved these changes
Apr 21, 2019
jackysp
added a commit
to jackysp/tidb
that referenced
this pull request
Apr 24, 2019
…ling the strict SQL mode (pingcap#10161)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix #10153 , disabling the strict SQL mode should not ignore the bad null error.
What is changed and how it works?
Fix it when resetting the context of the statement.
Check List
Tests
Code changes
Related changes