ddl: make the SyncerSessionTTL smaller #10371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #10371 +/- ##
================================================
- Coverage 80.2056% 80.1826% -0.0231%
================================================
Files 415 415
Lines 88313 88276 -37
================================================
- Hits 70832 70782 -50
- Misses 12256 12267 +11
- Partials 5225 5227 +2 |
zimulala
changed the title
zimulala
added
status/LGT2
|
/run-all-tests |
zimulala
added a commit
to zimulala/tidb
that referenced
this pull request
Jun 13, 2019
winkyao
pushed a commit
that referenced
this pull request
Jun 13, 2019
zimulala
added a commit
to zimulala/tidb
that referenced
this pull request
Jun 13, 2019
zimulala
added a commit
that referenced
this pull request
Jun 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
If we do "kill -9" to TiDB, the DDLAllSchemaVersions path doesn't be removed, and it will be automatically removed after a TTL.
If this path doesn't be removed, then changing a DDL state requires waiting for 2 * lease.
What is changed and how it works?
Make the SyncerSessionTTL smaller
Related changes